[serialization] Yet Another Misuse of ArrayRef #5216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wonder if we can assert that the lifetime is valid or something. rdar://problem/28699599
|
@bob-wilson Can you review this? @swift-ci Please smoke test |
|
LGTM |
benlangmuir
pushed a commit
to benlangmuir/swift
that referenced
this pull request
Oct 19, 2016
I wonder if we can assert that the lifetime is valid or something. rdar://problem/28699599
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this one by guessing which file was the problem, compiling it with -O0, and seeing if things got better, then marking the problematic ArrayRef constructors as
deprecatedand seeing if we were using any in that file (which we were). This is not a good workflow.rdar://problem/28699599