Sil verify all verify functions when added to worklist #5221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An int is already constant and in general in LLVM style we do not create such const ints. On the other hand, a constexpr I think expresses the intent slightly better and gives the compiler more freedom anyways.
…be more explicit.
|
@swift-ci Please smoke test |
|
Oops... pushed an older version. 1 sec |
…ions after adding them to the worklist. When SILVerifyAll is enabled, individual functions are verified after function passes are run upon them. This means that any functions created by a function pass will not be verified after the pass runs. Thus specialization errors that cause the verifier to trip will be misattributed to the first pass that makes a change to the specialized function. This is very misleading and increases triage time. This change eliminates that problem by ensuring that when SILVerifyAll is enabled, we always verify newly specialized functions as they are added to the worklist. rdar://28706158
gottesmm
force-pushed
the
sil_verify_all_verify_functions_when_added_to_worklist
branch
from
284555f to
1ba8182
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test linux platform |
|
Now that I think about it, given that this can potentially cause the verifier to trigger many more times, I really need to do a full test to be careful. |
|
(specifically since I could expose bad code patterns to the verifier that previously were DCEed or the like). |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
These are from the earlier "oops" version. Not sure why it took so long for this post to land though. @shahmishal Might be a sign of a bigger problem.
|
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@shahmishal My tests failed I think b/c of infrastructure issues. Can you take a look? |
|
@swift-ci Please test |
|
Linux smoke test failed due to |
Time out was due to no output to console for 300mins. Test getting stuck? |
|
Other Linux failure is due to |
gottesmm
deleted the
sil_verify_all_verify_functions_when_added_to_worklist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SILVerifyAll is enabled, individual functions are verified after
function passes are run upon them. This means that any functions created
by a function pass will not be verified after the pass runs. Thus
specialization errors that cause the verifier to trip will be
misattributed to the first pass that makes a change to the specialized
function. This is very misleading and increases triage time.
As a result, when SILVerifyAll is enabled, we always verify newly
specialized functions as they are added to the worklist.