[CMake] Replace APPLE with CMAKE_HOST_APPLE #5231
Conversation
In CMake `APPLE` is defined if you are *targeting* an Apple platform (or at least if CMake thinks you are). If your host is an Apple platform CMake defines `CMAKE_HOST_APPLE`. Swift's build system is rolling its own cross-compiling support, so checks such as `APPLE` do not function properly, and instead are true when the *host* is `APPLE`. To make that fact explicit, change these variables to `CMAKE_HOST_APPLE`.
|
I don't think this is correct. We don't care about the system SourceKit is being built on; we care about where it will be run. |
|
@jrose-apple is right on these checks. These You may need to feed an SDK check in through here. |
|
An SDK check isn't correct either—there may be up to three systems here:
Obviously if "build" and "host" are different then you can't build any target libraries in this compilation (at least without using some kind of "native tools", which we do have a setting for), but that may be okay. |
|
I'll close this for now, in favor of a broader approach (hopefully) coming soon. |
In CMake
APPLEis defined if you are targeting an Apple platform (or at least if CMake thinks you are). If your host is an Apple platform CMake definesCMAKE_HOST_APPLE.Swift's build system is rolling its own cross-compiling support, so checks such as
APPLEdo not function properly, and instead are true when the host isAPPLE. To make that fact explicit, change these variables toCMAKE_HOST_APPLE.Addresses a comment by @llvm-beanz on #5160 (comment).