[ClangImporter] Fix another lifetime extension issue. #5255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test and merge |
The StringRef here referred to a temporary std::string. rdar://problem/28699869
jrose-apple
force-pushed
the
ClangImporter-StringRef-issue
branch
from
1a91f62 to
036520f
Compare
|
@swift-ci Please smoke test and merge |
|
@jrose-apple Do you know what's going on with Linux here? |
|
Hm, no, that doesn't look related. @ddunbar, does this look familiar? |
|
@swift-ci Please smoke test |
|
@shahmishal This one flagged the wrong commit again. https://ci.swift.org/job/swift-PR-Linux-smoke-test/1783/ |
benlangmuir
pushed a commit
to benlangmuir/swift
that referenced
this pull request
Oct 19, 2016
The StringRef here referred to a temporary std::string. rdar://problem/28699869 Conflicts: lib/ClangImporter/ClangImporter.cpp
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 7, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The StringRef here referred to a temporary std::string.
rdar://problem/28699869