[sil-performance-inliner] Re-introduce inlining of generics as a staging feature behind a flag #5265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test and merge |
|
@swift-ci Please smoke test |
swiftix
force-pushed
the
wip-generics-inlining-flag
branch
from
cfcce5a to
489f6c5
Compare
|
@swift-ci Please smoke test |
…ing feature behind a flag Use the following options to enable this flag: -Xllvm -sil-inline-generics Generic inlining is now handled by a dedicated logic in isProfitableToInlineGeneric. This makes it easier to find this logic. And it will make it easier to extend and improve it in the future. The initial policy for generic inlining is: - unconditionally inline generic functions if the -sil-inline-generics flag is used. - If the flag is not used, only perform generic inlining of always_inline and transparent functions. There are slight standard library's code-size regressions with this policy. They will be addressed by the future work on the generic inlining.
swiftix
force-pushed
the
wip-generics-inlining-flag
branch
from
489f6c5 to
91f5b9d
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please clean smoke test OS X |
|
@swift-ci Please test |
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 7, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the following options to enable this flag: -Xllvm -sil-inline-generics
Generic inlining is now handled by a dedicated logic in isProfitableToInlineGeneric. This makes it easier to find this logic. And it will make it easier to extend and improve it in the future.
The initial policy for generic inlining is:
There are slight standard library's code-size regressions with this policy. They will be addressed by the future work on the generic inlining.