Skip to content

[Version] Don't allow effective sub-versions, only major versions #5275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 19, 2016
Merged

[Version] Don't allow effective sub-versions, only major versions #5275

merged 3 commits into from
Oct 19, 2016

Conversation

milseman
Copy link
Member

Don't allow effective sub-versions, only major versions

@milseman
Copy link
Member Author

@swift-ci please smoke test

@milseman
Copy link
Member Author

@swift-ci please smoke test

milseman referenced this pull request Oct 13, 2016
@milseman
[swift-version] Allow swift-version 4 and tests
12fb0ba 
The recent @escaping on variadic argument closures back-compat fix is
the first Swift 3.0 compatibility behavior that we don't want to carry
forwards indefinitely into the future. To address this, we
version-gate the diagnostic suppression.

Makes it an official compatibility check. Creates new test directory
for compatibility testing. Allow -swift-version 4 so that we can test
it both ways.
@jdfweb
Copy link

jdfweb commented Oct 13, 2016

I agree

@milseman
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 4737e116ac25aab84dc4e0a5a3718080392c3a59
Test requested by - @milseman

@milseman
Copy link
Member Author

@erg, that failure is from before my new push.

@swift-ci please smoke test

@milseman
Copy link
Member Author

@swift-ci please test

@milseman
Copy link
Member Author

@swift-ci please smoke test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - b23787a740d95496c1e58c534234361bc111a825
Test requested by - @milseman

@milseman
Copy link
Member Author

@swift-ci please smoke test

1 similar comment
@milseman
Copy link
Member Author

@swift-ci please smoke test

@milseman
Copy link
Member Author

Linux failure: /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test@2/branch-master/swiftpm/Sources/PackageLoading/Module+PkgConfig.swift:11:8: error: module file was created by an older version of the compiler; rebuild 'Basic' and try again: /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test@2/branch-master/buildbot_linux/swiftpm-linux-x86_64/debug/Basic.swiftmodule

Is this due to incremental build?

@milseman
Copy link
Member Author

@erg

@milseman
Copy link
Member Author

@swift-ci please clean smoke test linux platform

@milseman milseman merged commit a595615 into swiftlang:master Oct 19, 2016
@milseman milseman deleted the escaping branch April 7, 2017 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milseman @jdfweb @swift-ci