Skip to content

[swift-3.0-branch] Fix dispatch time comparisons (#5078) #5298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2016
Merged

[swift-3.0-branch] Fix dispatch time comparisons (#5078) #5298

merged 1 commit into from
Oct 31, 2016

Conversation

lilyball
Copy link
Contributor

@lilyball lilyball commented Oct 14, 2016 •
edited by moiseev
Loading

This is a cherry-pick of #5078.

  • Explanation: Correct implementation of DispatchWallTime.< operator.
  • Scope of Issue: The existing implementation does not handle the DispatchWallTime.distantFuture values correctly and crashes on some values.
  • Origination: Incorrect original implementation.
  • Risk: Minimal.
  • Reviewed By: Matt Wright
  • Testing: Running an updated unit test suite.
  • Directions for QA: N/A

rdar://problem/29028859

@lilyball
Fix dispatch time comparisons (swiftlang#5078)
6c0c409 
* [Dispatch] Don't crash when comparing DispatchWallTimes with <

* [Dispatch] Make comparisons with distantFuture work as expected
@lilyball lilyball mentioned this pull request Oct 14, 2016
Merged
@ematejska
Copy link
Contributor

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 6c0c409
Test requested by - @ematejska

@moiseev
Copy link
Contributor

moiseev commented Oct 19, 2016

@swift-ci Please test Linux platform

@moiseev moiseev changed the title Fix dispatch time comparisons (#5078) [swift-3.0-branch] Fix dispatch time comparisons (#5078) Oct 31, 2016
@moiseev
Copy link
Contributor

moiseev commented Oct 31, 2016

Just to make sure it's still good.
@swift-ci Please test

@airspeedswift airspeedswift merged commit 8784fb1 into swiftlang:swift-3.0-branch Oct 31, 2016
@lilyball lilyball deleted the swift_3_dispatch_time_comparisons branch December 21, 2016 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lilyball @ematejska @swift-ci @moiseev @airspeedswift