Fixes for witness method devirtualization #5306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@eeckstein Erik, do you mind taking a look? |
|
LGTM! Thanks for fixing this Just a minor suggestion: maybe it makes sense to factor out the code which checks for legal upcasts in to a utility function. If you like you can do this in a separate commit |
swiftix
force-pushed
the
fixes-for-witness-method-devirt
branch
from
8faa7fa to
69cf720
Compare
|
@eeckstein Do you mean something like what I just pushed? |
|
Yes, and also use this function in SILVerifier::checkUpcast. (Of course we would have only a single failure-message then, but I think this is OK). |
Before generating an upcast instruction, make sure that the required type conversion is valid. Fixes rdar://28601761
…te types of existentials - Do not try to make a lookup type of a witness_method more concrete if it not an opened existential. - Replace witness_method instruction by a new one with a more concrete type only in the specific apply instruction instead of doing it everywhere. This allows for more optimization opportunities if the same witness_method is used by multiple apply instructions.
swiftix
force-pushed
the
fixes-for-witness-method-devirt
branch
from
69cf720 to
1e6edcb
Compare
|
@swift-ci Please smoke test |
swiftix
added a commit
to swiftix/swift
that referenced
this pull request
Oct 17, 2016
…od-devirt Fixes for witness method devirtualization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of issues in sil-combine and devirtualizer.
Resolves SR-2623.