Added new frontend flag to accelerate clang importer #5316
Conversation
|
@jrose-apple @benlangmuir thoughts? |
| @@ -345,6 +344,10 @@ getNormalInvocationArguments(std::vector<std::string> &invocationArgStrs, | |||
| SHIMS_INCLUDE_FLAG, searchPathOpts.RuntimeResourcePath, | |||
| }); | |||
|
|
|||
| if (!importerOpts.DisableModulesValidateSystemHeaders) { | |||
| invocationArgStrs.push_back("-fmodules-validate-system-headers"); | |||
| } | |||
There was a problem hiding this comment.
Nitpick: Can you move this down to the end of the function where the other importerOpts options are checked?
There was a problem hiding this comment.
You sure? I thought up here next to all the module stuff.
There was a problem hiding this comment.
It's supposed to be "universal arguments that don't change", "platform-based arguments that don't change", and then "conditional arguments and arguments with values". I guess that's not so clear from what's there.
There was a problem hiding this comment.
Ok makes sense. I will update that.
| @@ -224,6 +224,9 @@ def disable_sil_linking : Flag<["-"], "disable-sil-linking">, | |||
| def dump_clang_diagnostics : Flag<["-"], "dump-clang-diagnostics">, | |||
| HelpText<"Dump Clang diagnostics to stderr">; | |||
|
|
|||
| def disable_modules_validate_system_headers : Flag<["-"], "disable-modules-validate-system-headers">, | |||
| HelpText<"Disable modules validate system headers in the clang importer">; | |||
There was a problem hiding this comment.
Nitpick: This text could use a bit of cleanup, even if it's not really going to be seen by anyone. "Disable validating system headers in the Clang importer", perhaps?
|
Seems fine to me. Ben? |
|
I agree the help message should be tweaked. Otherwise LGTM. |
…rom clang importer flags
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
This patch adds a new frontend flag
-disable-modules-validate-system-headersthat stops the clang importer from passing-fmodules-validate-system-headers. See clang for why you would want to pass this flag.