Fixed a bug in StmtConditionElement::getSourceRange where it would create invalid source ranges #5323
Conversation
…eate invalid source ranges This bug was causing an assert.
| else | ||
| Start = getPattern()->getStartLoc(); | ||
|
|
||
| SourceLoc End = getInitializer()->getEndLoc(); |
There was a problem hiding this comment.
I'm really not happy with this duplicated logic. At this point it probably makes sense to just not implement getStartLoc and getEndLoc, right?
There was a problem hiding this comment.
I thought not because of the bool and availability cases, they never need to find the other loc when asked.
There was a problem hiding this comment.
I suppose that's true. In that case, maybe in this case it delegates to getSourceRange?
There was a problem hiding this comment.
Then it would recheck the kind, we could just make a static function for this case.
There was a problem hiding this comment.
Inlining should take care of that.
There was a problem hiding this comment.
Ok then. I will update it.
… getSourceRange instead
|
Amended. |
|
@swift-ci Please smoke test and merge |
1 similar comment
|
@swift-ci Please smoke test and merge |
Fixed a bug in StmtConditionElement::getSourceRange where it would create invalid source ranges.
This bug was causing an assert. Now it creates valid source ranges.