Skip to content

Fixed a bug in AssignExpr that caused it to create invalid source ranges #5324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2016
Merged

Fixed a bug in AssignExpr that caused it to create invalid source ranges #5324

merged 1 commit into from
Oct 17, 2016

Conversation

mxswd
Copy link
Contributor

@mxswd mxswd commented Oct 17, 2016

The previous fix was invalid, implicit is an orthogonal idea to validity of source ranges.

@jrose-apple

@DougGregor
Copy link
Member

LGTM!

@jrose-apple
Copy link
Contributor

@swift-ci Please smoke test and merge

@swift-ci swift-ci merged commit 0ce9aef into swiftlang:master Oct 17, 2016
@mxswd mxswd deleted the fix-assignexpr branch October 18, 2016 02:26
@lattner
Copy link
Contributor

lattner commented Oct 18, 2016

Nice, thanks @mxswd !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants