[SR-2855] Show args mismatch in -driver-show-incremental #5336
Conversation
modocache
force-pushed
the
sr-2855-driver-show-incremental-args
branch
2 times, most recently
from
fd56ba8 to
a9a2ceb
Compare
| if (ShowIncrementalBuildDecisions) { | ||
| llvm::outs() << "Incremental compilation has been disabled, because " | ||
| << "different arguments were passed to the compiler.\n" | ||
| << "\tCompiling with argument hash: " << argsHashStr << "\n" |
There was a problem hiding this comment.
I'm not sure printing the hash is useful. There's not really anything people can do with it.
There was a problem hiding this comment.
I agree. I also think printing "because different arguments were used" would be frustrating -- I'd ideally like to know how they differed. Should I try to print out the delta here, or is that too much work?
There was a problem hiding this comment.
I guess we could just store the old argument list verbatim, in addition to the hash? The only time you'll see it is when you change something that does affect the output.
SR-2855 suggests `-driver-show-incremental` not only print information about why certain files are included in incremental compilation, but also print out why incremental compilation may be disabled altogether. Add a message for one such reason: when the arguments passed to the Swift compiler don't match the ones used previously.
modocache
force-pushed
the
sr-2855-driver-show-incremental-args
branch
from
a9a2ceb to
0e760b5
Compare
|
@jrose-apple For now, I've removed the argument hashes. I could store the argument lists as part of this commit, or (my preference) as a future improvement. |
|
@swift-ci please smoke test |
SR-2855 suggests
-driver-show-incrementalnot only print information about why certain files are included in incremental compilation, but also print out why incremental compilation may be disabled altogether.Add a message for one such reason: when the arguments passed to the Swift compiler don't match the ones used previously.
This addresses one part of SR-2855.