[ASTVerifier] Crash in a nice way if the last GenericEnvironment is NULL #5348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On every `pushScope` the generic environment of this scope is appended to `GenericEnv`. If the pushed `DeclContext` isn't generic, `NULL` is pushed leading to a crash only in `DenseMap::find` if some archetypes escaped their generic context.
|
Good catch. |
|
@swift-ci Please smoke test and merge |
|
The failure seems unrelated and should be fixed by #5372 |
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On every
pushScopethe generic environment of this scope is appendedto
GenericEnv. If the pushedDeclContextisn't generic,NULLispushed leading to a crash only in
DenseMap::findif some archetypesescaped their generic context.