[sourcekitd] Replace a slow std::regex with custom parsing #5350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gave a roughly 40-45% improvement in sourcekitd's incremental syntax-only parse time in files with a lot of doc comments (test case was ~6000 lines, with ~780 lines being doc comments). This is on the critical path for every edit. While there were a few smaller improvements we could have made to the original code, ultimately std::regex is slow, and it was better to just use a custom parser for these simple patterns. rdar://problem/28809397
|
@swift-ci Please smoke test |
|
@bitjammer could you review this for me? |
|
Awesome. Looking. |
|
Looks good to me! I wonder if, at some point, we should take advantage of the parsed structure of the doc comment, provided it's not parsed over and over again and we wire up source ranges, but that's for another day. Got rid of a regex! Now we have two fewer problems! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gave a roughly 40-45% improvement in sourcekitd's incremental
syntax-only parse time in files with a lot of doc comments (test case
was ~6000 lines, with ~780 lines being doc comments). This is on the
critical path for every edit.
While there were a few smaller improvements we could have made to the
original code, ultimately std::regex is slow, and it was better to just
use a custom parser for these simple patterns.
rdar://problem/28809397