Sourcekit cmake changes #5353
Merged
Sourcekit cmake changes #5353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 18, 2016 13:38
Reset Darwin specific CMake variables to match the correct SDK and architecture. This is needed when cross compiling, or we'll end up with conflicting SDK and architectures. Remove unused variable SOURCEKIT_GLOBAL_DEPLOYMENT_TARGET_FLAGS.
|
@swift-ci Please test Linux platform |
|
@swift-ci Please test |
|
@erg can you explain why we can't install the native tools when cross-compiling? I use that feature. |
|
@karwa I'm looking into it. What's your use case? |
|
Just "regular" cross-compiling for armv7/linux from macOS. I've got a script which builds packages for both platforms in one invocation. Everything is already built (for all platforms) before we install for any platform, so it's weird if anything fails because of the host products being installed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to help SourceKit build correctly.