Tighten up @objc optional near-miss detection heuristics.
#5367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The @objc optional requirement near-miss heuristics were too permissive, and could occasionally produce ridiculous results that were nowhere close to a "near" miss. Make the diagnostics more conservative, and fix an issue with an errant sentinel value. Fixes rdar://problem/26380688.
|
@swift-ci please smoke test and merge |
|
Not it! Assertion failed: (!type->hasArchetype() && "not fully substituted"), function mapTypeOutOfContext, file /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/lib/AST/GenericEnvironment.cpp, line 62. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@objcoptional requirement near-miss heuristics were toopermissive, and could occasionally produce ridiculous results that
were nowhere close to a "near" miss. Make the diagnostics more
conservative, and fix an issue with an errant sentinel value.
Resolves rdar://problem/26380688.