Revert "Make the option of building using the host clang the default" #5369
Conversation
This reverts commit 0b1e858. No one remembers what problems this caused for the ASan bot when we tried building the runtime with the just-built clang, so I'm reenabling it now and we'll see what happens.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please clean test |
|
(Just kicked off another test due to breakage earlier) |
|
Build failed |
|
Build failed |
|
@bob-wilson I think the problem may be that we are not exporting clang from LLVM's cmake. That is a known issue that we should probably just fix. When I originally implemented that I only needed it for libraries, so I didn't implement it for executables. I have a quick fix for this issue (its a 1 line patch in clang). Once that happens, things should just work. Give me 5. |
|
I just pushed the cherry-pick. Lets see if that fixes the issue. |
|
@swift-ci Please test |
|
It got through configure on OS X. I guess we just need to verify that it is using the just built clang in the correct places. |
|
Looks like it is doing the right thing: 18:30:20 [1141/3605] /Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/buildbot_incremental/llvm-macosx-x86_64/./bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -DswiftRemoteMirror_appletvos_arm64_EXPORTS -Istdlib/public/SwiftRemoteMirror -I/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/swift/stdlib/public/SwiftRemoteMirror -I/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/swift/include -Iinclude -I/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/llvm/include -I/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/buildbot_incremental/llvm-macosx-x86_64/include -I/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/buildbot_incremental/llvm-macosx-x86_64/tools/clang/include -I/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/llvm/tools/clang/include -I/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/cmark/src -I/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/buildbot_incremental/cmark-macosx-x86_64/src -fno-stack-protector -stdlib=libc++ -fPIC -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wcovered-switch-default -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Werror=date-time -std=c++11 -fcolor-diagnostics -Wdocumentation -Wimplicit-fallthrough -Wunreachable-code -Woverloaded-virtual -O3 -isysroot /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -fPIC -UNDEBUG -fno-exceptions -fno-rtti -target arm64-apple-tvos9.0 -isysroot /Applications/Xcode-beta.app/Contents/Developer/Platforms/AppleTVOS.platform/Developer/SDKs/AppleTVOS10.0.sdk -arch arm64 -F /Applications/Xcode-beta.app/Contents/Developer/Platforms/AppleTVOS.platform/Developer/SDKs/AppleTVOS10.0.sdk/../../../Developer/Library/Frameworks -mtvos-version-min=9.0 -O2 -g0 -UNDEBUG -MMD -MT stdlib/public/SwiftRemoteMirror/CMakeFiles/swiftRemoteMirror-appletvos-arm64.dir/SwiftRemoteMirror.cpp.o -MF stdlib/public/SwiftRemoteMirror/CMakeFiles/swiftRemoteMirror-appletvos-arm64.dir/SwiftRemoteMirror.cpp.o.d -o stdlib/public/SwiftRemoteMirror/CMakeFiles/swiftRemoteMirror-appletvos-arm64.dir/SwiftRemoteMirror.cpp.o -c /Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/swift/stdlib/public/SwiftRemoteMirror/SwiftRemoteMirror.cpp |
|
I think we were just hesitant to turn it on for everyone until we'd vetted it. |
This reverts commit 0b1e858.
No one remembers what problems this caused for the ASan bot when we
tried building the runtime with the just-built clang, so I'm reenabling
it now and we'll see what happens.