add requiresReabstraction flag / check(s) to RValueEmission #5405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rjmccall Can you please review? |
|
@swift-ci Please smoke test |
|
Hi Joe, can you please add a SILGen test? |
|
@slavapestov Unfortunately, We can't reproduce this issue / go into this code-path in Master (with any known code pattern), other modifications by @rjmccall hid this bug, the test would only work on the 3.0 branch - we actually need to cherry-pick this to 3.0 |
|
Yes, this looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
radar rdar://problem/28695190
This PR resolves a problem wherein an RValue that didn't need reabstraction goes through the slow reabstraction path with +0 to the retain count - causing a crash upon release of the value.
With this PR we avoid the unnecessary reabstractions + make sure the value is retained.