[semantic-arc] Wire up Parsing/Printing/IRGen/Serialization/Deserialization for copy_value, destroy_value. #5416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tialized_behavior. Noticed this while preparing copy_value, destroy_value. The problem was that we were not parsing the SIL Debug Location at the end of mark_uninitialized_behavior.
…zation for copy_value, destroy_value. rdar://28851920
|
@swift-ci Please smoke test and merge |
jrose-apple
reviewed
Oct 24, 2016
| @@ -992,6 +992,8 @@ void SILSerializer::writeSILInstruction(const SILInstruction &SI) { | |||
| } | |||
| case ValueKind::CondFailInst: | |||
| case ValueKind::RetainValueInst: | |||
| case ValueKind::CopyValueInst: | |||
| case ValueKind::DestroyValueInst: | |||
There was a problem hiding this comment.
Please bump the module format version number!
There was a problem hiding this comment.
I thought I did. I guess I did it in an earlier version of the patch. Sorry!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[semantic-arc] Wire up Parsing/Printing/IRGen/Serialization/Deserialization for copy_value, destroy_value.
Nothing crazy here, just implementing the instructions and basic support.
rdar://28851920