Skip to content

Fix test for 32 bit platforms by removing align from FileCheck pattern. #5422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2016

Conversation

gottesmm
Copy link
Contributor

Fix test for 32 bit platforms by removing align from FileCheck pattern.

@gottesmm
Copy link
Contributor Author

@swift-ci Please smoke test and merge

@gottesmm
Copy link
Contributor Author

@swift-ci Please test and merge

@gottesmm
Copy link
Contributor Author

I killed the smoke test and merge, since I want to do a full test here.

…ust makes the FileCheck handling more complicated.
@gottesmm gottesmm force-pushed the fix_32bit_irgen_copyvalue_test branch from 4e26c29 to 8b7d5e5 Compare October 24, 2016 07:58
@gottesmm
Copy link
Contributor Author

@swift-ci Please test and merge

1 similar comment
@gottesmm
Copy link
Contributor Author

@swift-ci Please test and merge

@swift-ci swift-ci merged commit 2dc96a9 into swiftlang:master Oct 24, 2016
@gottesmm gottesmm deleted the fix_32bit_irgen_copyvalue_test branch October 24, 2016 15:24
@jrose-apple
Copy link
Contributor

"REQUIRES=macosx" is very different from "disable for 32-bit". What are you actually trying to do?

@gottesmm
Copy link
Contributor Author

I just wanted to disable it for 32-bit. Otherwise, I would need to create two different runs one for 32 bit and one for 64 bit. That just adds redundant time to the build with no benefit.

I am pretty sure since I specified it as an OS check, this is fine.

@jrose-apple
Copy link
Contributor

I'm fine with you disabling 32-bit, but you've also disabled iOS and Linux testing too. That seems like a bad idea.

It looks like there's a REQUIRES: PTRSIZE=64; can you use that instead? Or REQUIRES: CPU=x86_64.

@gparker42
Copy link
Contributor

One non-disabling solution is:

  1. add --check-prefix=CHECK --check-prefix=CHECK-%target-ptrsize to your FileCheck invocation
  2. write both CHECK-32: and CHECK-64: lines for your checks that are pointer size specific.

@gottesmm
Copy link
Contributor Author

@gparker42 yea... I was trying to be lazy and not do that. I think jordan is right about PTRSIZE=64.

MaxDesiatov pushed a commit that referenced this pull request Sep 7, 2023
[pull] swiftwasm from main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants