Skip to content

Third batch of changelog edits #5427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2016
Merged

Third batch of changelog edits #5427

merged 1 commit into from
Oct 24, 2016

Conversation

erica
Copy link
Contributor

@erica erica commented Oct 24, 2016

@lattner Third (and final) Swift 3 batch of changelog edits. (I stopped at Swift 2.2)

SE-0057 only lightly edited because I did not want to change any meanings. It could use review by a second pair of eyes more familiar with this proposal.

SE-0005 was expanded (per request) and needs secondary review

Since this was the oldest section, I made the lightest edits, trying to preserve meaning but retain as much of the newer structure as possible. I've added a number of examples and tried to add explanations, similar to the newer changelog entries.

@lattner
Copy link
Contributor

lattner commented Oct 24, 2016

Looks great @erica thanks! One thing you can choose to do if you want: you can move the "Add new entries to the top of this file, not here!" marker to the end of the current section. We don't need it at the end of the Swift 3.0 section anymore.

@lattner lattner merged commit 05f4594 into swiftlang:master Oct 24, 2016
@erica
Copy link
Contributor Author

erica commented Oct 25, 2016

@lattner I'll go ahead and do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants