[semantic-arc] Change emitCopyValue entrypoints to return the copied SILValue. #5444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test and merge |
…SILValue. I have not updated any APIs that use the emitCopyValue entrypoints to properly propagate forward the returned value. The strategy for reforming the resulting value was to: 1. Return the retain_value operand in leaf cases. 2. In aggregate cases, just use reformAggregate to reform the aggregate from the copied leaf results. 3. In enums, since I deleted the deep code, this is the same as the leaf cases. Once I change in a subsequent commit the actual retain_value emission to instead be copy_value emission, then type lowering will be able to properly pair copy_value operations. rdar://28851920
gottesmm
force-pushed
the
return_copyvalue_result_from_typelowering
branch
from
0e8458e to
7f2ec61
Compare
|
Lets try this again... The test failed b/c before we were not reforming the aggregate and the test that broke used a ton of CHECK-NEXTs that were unnecessary. I changed them to just CHECK so that the interleaving instructions that reconstructed the aggregates are ignored. |
|
@swift-ci Please smoke test and merge |
1 similar comment
|
@swift-ci Please smoke test and merge |
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 7, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[semantic-arc] Change emitCopyValue entrypoints to return the copied SILValue.
I have not updated any APIs that use the emitCopyValue entrypoints to properly
propagate forward the returned value.
The strategy for reforming the resulting value was to:
copied leaf results.
Once I change in a subsequent commit the actual retain_value emission to instead
be copy_value emission, then type lowering will be able to properly pair
copy_value operations.
rdar://28851920