Skip to content

[Driver] Mark a few more flags as DoesNotAffectIncrementalBuild. #5480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jrose-apple
Copy link
Contributor

...so that adding or removing them doesn't force a rebuild.

...so that adding or removing them doesn't force a rebuild.
@jrose-apple
Copy link
Contributor Author

@modocache, can you sanity-check this?

@swift-ci Please smoke test

@modocache
Copy link
Contributor

LGTM, but after a cursory search I wasn't 100% sure if -save-temps truly has no effect on incremental compilation.

@jrose-apple
Copy link
Contributor Author

Yeah, that was the one that prompted this. I looked through all the existing uses, and I think we're good:

  • input and output file lists, always newly-generated
  • intermediate outputs not in an output file map, also always newly-generated
  • auxiliary outputs next to a primary output, if the primary output is a temporary file

Stepping back, if there is a problem with changing between -save-temps and not, there's probably a problem with successive -save-temps runs at well. So I think I've managed to convince myself this is safe.

(And -save-temps is really a debugging option anyway. An output file map is still the right way to keep intermediates around that aren't just infrastructure.)

@jrose-apple
Copy link
Contributor Author

I've re-read my own logic and reconvinced myself. Re-running tests just in case.

@swift-ci Please smoke test

@modocache
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants