Rdar 28786959 3.0 branch if swift 3 digit version #5482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR against master: #5440
Initial PR description:
Two changes, close relatives.
First change enables writing #if swift(>=3.0.1) by contextually inhibiting an early diagnostic in the parser that's currently blocking the initial semi-parse that runs before the Version parser kicks in.
Second change weakens our sense of logical order and logical equality on Version structures such that 4 == 4.0 == 4.0.0 (that is, versions are considered to have as many trailing zeroes as necessary). The function evaluating versions you are allowed to pass on the command line is tightened opposite this change, so you still can't say -swift-version 4.0 (only -swift-version 4) but it means that if someone writes #if swift(>=4.0) it'll work, rather than the current behaviour, that thinks 4 < 4.0.
Resolves SR-2908.