[3.0]: [build-script-impl]: Fixes version number on Linux from 3.0 to 3.0.x #5513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brief: COMPILER_VENDOR is None on Linux, so we get version 3.0 instead of 3.0.x. Full: On Linux, SWIFT_VERSION is unset because the ``None)`` case for ``COMPILER_VENDOR`` is empty. When ``lib/Basic/CMakeLists.txt`` tries to match the empty ``SWIFT_VERSION`` against regexps testing for a version triple, matching fails and we set ``DSWIFT_HAS_VERSION_PATCHLEVEL=0``. Then, in ``lib/Basic/Version.cpp``, since PATCHLEVEL is 0, it chooses the ``#else`` and ``SWIFT_VERSION_STRING`` is set to a pair instead of a triple, which gives ``3.0``.
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test OS X platform |
jrose-apple
approved these changes
Oct 28, 2016
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 7, 2023
[wasm] Revert unnecessary CC attr in Numeric.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux reports 3.0 instead of 3.0.x.
Testing then asking to merge.