[PrintAsObjC] Use of imported generics require the full definition. #5518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure why this didn't occur to me in 8282160: of course if you see a generic type with arguments, you need to see the @interface for that type in order to supply the arguments. Maybe I was thinking the generated interface would automatically import anything the module itself imports, but that hasn't ever been true. rdar://problem/28738008
|
@swift-ci Please smoke test Linux platform |
|
@swift-ci Please test macOS platform |
|
@DougGregor, mind reviewing this to make sure I'm not making a terrible mistake? |
|
Yeah, this looks good. |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Oct 31, 2016
…wiftlang#5518) I'm not sure why this didn't occur to me in 8282160: of course if you see a generic type with arguments, you need to see the @interface for that type in order to supply the arguments. Maybe I was thinking the generated interface would automatically import anything the module itself imports, but that hasn't ever been true. rdar://problem/28738008
ematejska
pushed a commit
that referenced
this pull request
Nov 1, 2016
…ics-again [PrintAsObjC] Use of imported generics require the full definition. (#5518)
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 7, 2023
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why this didn't occur to me in 8282160: of course if you see a generic type with arguments, you need to see the
@interfacefor that type in order to supply the arguments. Maybe I was thinking the generated interface would automatically import anything the module itself imports, but that hasn't ever been true.rdar://problem/28738008