Skip to content

[WIP] SIL type lowering cleanups #5524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[WIP] SIL type lowering cleanups #5524

wants to merge 5 commits into from

Conversation

slavapestov
Copy link
Contributor

No description provided.

@gottesmm
Copy link
Contributor

Slava, I am going to be landing some TypeLowering stuff today, can you please wait until that lands?

@gottesmm
Copy link
Contributor

This is the PR that I am worried about: #5494

@gottesmm
Copy link
Contributor

Its done! Thanks I appreciate it = ).

@slavapestov
SIL: Simplify some code in SIL verifier now that optional payloads ar…
aae1252 
…e lowered
@slavapestov
SIL: Kill off GenericContextScope
f562aca
@slavapestov
AST: Replace ASTContext::getOrCreateArchetypeBuilder() with getCanoni…
c965a3c 
…calGenericEnvironment()

Instead of keeping around an entire ArchetypeBuilder, it suffices
to build a GenericEnvironment instead, and use it for queries by
mapping interface types to archetypes.
@slavapestov
AST: Remove SILType variant of ArchetypeBuilder::substDependentType()
620b805 
This is no longer needed.
@slavapestov
AST: Make ArchetypeBuilder::substDependentType() private
328888a
@tkremenek
Copy link
Member

@swift-ci test

@tkremenek
Copy link
Member

@slavapestov Is this ready to be merged?

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 328888a
Test requested by - @tkremenek

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 328888a
Test requested by - @tkremenek

@tkremenek
Copy link
Member

Looks like this patch no longer builds.

@slavapestov
Copy link
Contributor Author

@tkremenek No, this is still a work in progress.

@slavapestov slavapestov mentioned this pull request Jan 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slavapestov @gottesmm @tkremenek @swift-ci