[TypeChecker] Add error message when accessing a type's destructor #5536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide error messages when the destructor is accessed using foo.deinit instead of crashing This resolves SR-2652 and SR-3043
|
@swift-ci please test |
|
Build failed |
|
I can't really make sense of the build failure on Linux in llbuild. Could someone help me spot what the issue is? (I don't have a Linux installation locally and all my Mac tests pass). Will run the CI again in the meantime to check if it was just a temporary problem. @swift-ci please test linux platform |
|
OK, seems like the Linux test failures were nondeterministic or related to something else |
|
This LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to access a destructor using
foo.deinitcurrently crashes the compiler. This pull requests makes the compiler create error messages instead.Resolves SR-2652/SR-3043.