Skip to content

SILGen: Check for a null emission context before dereferencing. #5561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2016
Merged

SILGen: Check for a null emission context before dereferencing. #5561

merged 1 commit into from
Oct 31, 2016

Conversation

jckarter
Copy link
Contributor

@jckarter
Copy link
Contributor Author

@swift-ci Please smoke test and merge

@jckarter
Copy link
Contributor Author

@slavapestov Does this look good for 3.0?

slavapestov
slavapestov reviewed Oct 31, 2016
View reviewed changes
test/SILGen/reabstract-tuple.swift

// SR-3090:

class Box<T> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the test have CHECK: lines and go into one of the existing files where we test reabstraction?

But you can fix that on master, this looks good for 3.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. I figured the code was otherwise obvious enough that -verifying it was sufficient.

@jckarter jckarter merged commit 1ba8939 into swiftlang:master Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jckarter @slavapestov