IRGen: Don't emit reflection metadata for builtin types unless we're … [3.0] #5562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…building the standard library I couldn't reduce a test case, but it seems to come up with optimizations enabled. We should have already emitted metadata for everything when we built the stdlib, no need to do it again. Fixes <rdar://problem/28924516>.
|
@swift-ci Please test macOS |
|
@bitjammer Can you please review? |
|
LG. |
slavapestov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes an issue that was coming up in release builds with optimization enabled.
Scope of the issue: Affects anyone building Swift projects with reflection enabled (which is the default).
Risk: Low.
Tested: No automated test, but user project that exhibited the issue now builds.
Reviewed by: @bitjammer
Bug: rdar://problem/28924516