SILGen: Add AnyHashable erasure support for function conversions [3.0] #5563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When AnyHashable was added, SILGen gained support for lowering AnyHashableErasureExpr, however we forgot to also add support for AnyHashable parameter and result conversions to FunctionConversionExpr. Fixes <https://bugs.swift.org/browse/SR-2603>.
|
@swift-ci Please test macOS |
|
@jckarter Do you mind reviewing this for 3.0? |
|
Looks good. |
slavapestov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: When AnyHashable was added in Swift 3, we forgot to update SILGen's function conversion path to support it.
Scope of the issue: The bug is pretty obscure but at least in the reported case, it is unclear to the user that AnyHashable is used at all, or what the workaround is.
Risk: Low.
Tested: New automated test added.
Bug: https://bugs.swift.org/browse/SR-2603 and rdar://problem/28787005
Reviewed by: @jckarter