Skip to content

swift-sdk-digester: simplify change descriptions to allow expected output to be empty #5580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2016
Merged

swift-sdk-digester: simplify change descriptions to allow expected output to be empty #5580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/api-digester/Outputs/Cake.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@

==================================================== Removed Decls ====================================================
/* Removed Decls */

==================================================== Moved Decls ====================================================
/* Moved Decls */

==================================================== Renamed Decls ====================================================
/* Renamed Decls */

==================================================== Type Changes ====================================================
/* Type Changes */
Constructor S1.init(_:) has 1st parameter type change from Int to Double
Func C1.foo2(_:) has 1st parameter type change from Int to () -> ()

==================================================== Decl Attribute changes ====================================================
/* Decl Attribute changes */
Var C1.CIIns1 changes from weak to strong
Var C1.CIIns2 changes from strong to weak
Func C1.foo1() is now not static
Expand Down
11 changes: 3 additions & 8 deletions test/api-digester/source-stability.swift.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@

==================================================== Removed Decls ====================================================
/* Removed declarations */
Protocol BidirectionalIndexable has been removed (deprecated)
Protocol ExpressibleByStringInterpolation has been removed (deprecated)
Protocol Indexable has been removed (deprecated)
Expand All @@ -8,15 +7,11 @@ Protocol MutableIndexable has been removed (deprecated)
Protocol RandomAccessIndexable has been removed (deprecated)
Protocol RangeReplaceableIndexable has been removed (deprecated)

==================================================== Moved Decls ====================================================
/* Moved declarations */
// rdar://28456614 Swift 3 breaking change: static function 'abs' removed from Double/Float/Float80/CGFloat
Func Double.abs(_:) has been moved to Func abs(_:)
Func Float.abs(_:) has been moved to Func abs(_:)
Func Float80.abs(_:) has been moved to Func abs(_:)

==================================================== Renamed Decls ====================================================

==================================================== Type Changes ====================================================
/* Function type change */
Func UnsafePointer.withMemoryRebound(to:capacity:_:) has 3rd parameter type change from (UnsafeMutablePointer<T>) throws -> Result to (UnsafePointer<T>) throws -> Result

==================================================== Decl Attribute changes ====================================================
4 changes: 2 additions & 2 deletions tools/swift-api-digester/swift-api-digester.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2700,9 +2700,9 @@ class DiagnosisEmitter : public SDKNodeVisitor {
struct DiagBag {
std::vector<T> Diags;
~DiagBag() {
llvm::outs() << "\n==================================================== ";
llvm::outs() << "\n/* ";
T::theme(llvm::outs());
llvm::outs() << " ====================================================\n";
llvm::outs() << " */\n";
removeRedundantAndSort(Diags);
std::for_each(Diags.begin(), Diags.end(), [](T &Diag) {
Diag.output();
Expand Down