[benchmark][SR-3106] Add benchmarks with 4 different Observers #5583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent ways These benchmarks highlight optimization opportunities in the implementation of partially applied methods and escaping closures. # TEST SAMPLES MIN(μs) MAX(μs) MEAN(μs) SD(μs) MEDIAN(μs) MAX_RSS(B) 97 ObserverClosure 10 2547 2752 2599 0 2599 308317798 98 ObserverForwarderStruct 10 1345 1972 1480 0 1480 614535987 99 ObserverPartiallyAppliedMethod 10 3953 4194 4049 0 4049 267670733 100 ObserverUnappliedMethod 10 2990 3482 3093 0 3093 338796544
|
@swift-ci Please smoke test and merge |
|
@swift-ci Please smoke test linux platform |
|
Not sure why the timeout occurred when compiling xctest. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds four benchmarks to Swift's benchmark suite that highlight optimization opportunities in the implementation of partially applied method invocations and escaping closures.
It augments (but does not resolve) SR-3106, in which I complain about their slowness relative to hand-written forwarding structs.
Here is a typical run on my system: (2012 15" rMBP):
I'd have expected partially applied method invocations to be just as fast as hand-written method forwarding structs stored inside protocol existentials. In fact, in these benchmarks, they are almost three times slower than that, and two times slower than plain closures.