[ClangImporter] C static-qualified array params are non-nullable. #5617
Conversation
|
@milseman bump |
|
I left a code review question @jrose-apple edit: Oh crap! It didn't save! My bad |
| return translateNullability(*nullability); | ||
| } | ||
|
|
||
| // If it's known non-null, use that. | ||
| if (knownNonNull || param->hasAttr<clang::NonNullAttr>()) | ||
| return OTK_None; | ||
|
|
||
| // Check for the 'static' annotation on C arrays. | ||
| if (!swiftVersion.isVersion3()) | ||
| if (const auto *DT = dyn_cast<clang::DecayedType>(paramTy)) |
There was a problem hiding this comment.
Is the intent here for 4 and later, or this a problem only in swift 3?
There was a problem hiding this comment.
"4 and later". I'm honestly not sure what our idiom should be here (why do we have a particular accessor at all?). @graydon?
There was a problem hiding this comment.
Just a convenience accessor, I figured people sprinkling explicit version comparisons in their code would be worse.
(nb: there's no support for setting --swift-version earlier than 3 so "not 3" means >= 3 in this case, but probably a more explicit convenience accessor would be better.)
There was a problem hiding this comment.
I guess in the C world you don't say "C > 99" or something. It's only because we have sequential version numbers that we even have this option.
In Clang we check for the new version of the language (if (LangOpts.C99), if (LangOpts.CXX14)), but those checks are designed to stay around. Checking isVersion3 feels like a reminder that the check will go away if/when we drop support for Swift 3 mode.
If the keyword 'static' also appears within the '[' and ']' of the
array type derivation, then for each call to the function, the
value of the corresponding actual argument shall provide access to
the first element of an array with at least as many elements as
specified by the size expression. (C11 6.7.6.3p7)
Limit this change to Swift 4 so as not to break existing code, though
use of 'static' in this way is rare to begin with and passing nil
would probably be an error anyway.
Small part of rdar://problem/25846421.
jrose-apple
force-pushed
the
static-qualified-arrays
branch
from
683cdd7 to
544b4e8
Compare
|
@swift-ci Please smoke test |
Limit this change to Swift 4 so as not to break existing code, though use of
staticin this way is rare to begin with and passing nil would probably be an error anyway.Small part of rdar://problem/25846421.