Skip to content

Set default value for EnumerateGenerator.count #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2015

Conversation

frootloops
Copy link
Contributor

No description provided.

gribozavr added a commit that referenced this pull request Dec 16, 2015
Set default value for EnumerateGenerator.count
@gribozavr gribozavr merged commit 2f538f8 into swiftlang:master Dec 16, 2015
@dabrahams
Copy link
Contributor

@frootloops @gribozavr I’m not entirely convinced this was an improvement. Now initialization logic is scattered. Why do we want to make this change?

@gribozavr
Copy link
Contributor

We generally use inline initializers where it makes sense. It does make the initialization logic more scattered, I agree. Are you against using inline initializers in general or is this case special?

@dabrahams
Copy link
Contributor

I don’t have a general principle against them, but this particular case looks like a glaring example of an arbitrary change that doesn’t improve readability—if anything, it hurts readability—and creates needles VCS churn. I would generally prefer to use inline initializers where it helps readability.

freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants