[semantic-arc] Handle the rest of the unqualified mem opts in SILGen. #5692
Conversation
|
I have 2x DI tests to fix still (gotta love it). But in the mean time, I want to start the testing on Linux/simulators. |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
gottesmm
force-pushed
the
change_silgen_emit_qualified_loadstrong
branch
from
3a7be4a to
45fed52
Compare
|
I am pretty sure the DI bugs are use-list ordering issues since I am running the ownership model eliminator before running DI. Really the first priority should be moving the ownership model eliminator /after/ DI to prevent these issues. |
Keep in mind that these are approximations that will not impact correctness since in all cases I ensured that the SIL will be the same after the OwnershipModelEliminator has run. The cases that I was unsure of I commented with SEMANTIC ARC TODO. Once we have the verifier any confusion that may have occurred here will be dealt with. rdar://28685236
…operations, tighten up the verifier in functions with qualified ownership. rdar://28685236
… for DI violations, not class_method. This is working around an additional use-list DI ordering issue that I exposed when implementing High Level Memory Operations. Specifically, DI started to error on: (class_method x) instead of on: (apply (class_method x) x) We would also try to emit an error on the apply, but we would squelch the apply error (which is more accuracte) since we had already emitted the class_method error. This commit conservatively checks for this condition and skips the class method so we can emit the more descriptive error on the apply.
gottesmm
force-pushed
the
change_silgen_emit_qualified_loadstrong
branch
from
45fed52 to
35acc0f
Compare
|
@swift-ci Please test and merge |
1 similar comment
|
@swift-ci Please test and merge |
|
@swift-ci Please smoke test and merge |
|
OS X passed the full test, but linux failed due to a libstdc++ issue. The commit I just pushed fixed the issue. This should not affect the full test results on OS X, so I am just going to do a smoke test. |
|
@swift-ci Please smoke test and merge |
[semantic-arc] Handle the rest of the unqualified mem opts in SILGen.
Keep in mind that these are approximations that will not impact correctness
since in all cases I ensured that the SIL will be the same after the
OwnershipModelEliminator has run. The cases that I was unsure of I commented
with SEMANTIC ARC TODO. Once we have the verifier any confusion that may have
occurred here will be dealt with.
rdar://28685236