[test] Fix three Driver tests under cross-compilation. #5694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driver exits out early if there's no stdlib for the target you're compiling for, and these tests didn't pass a target for one reason or another. rdar://problem/29173390
|
Running full tests since this bug is related to targets. @swift-ci Please test |
|
@rudkx, @shahmishal Looks like this test is hanging. Have we seen this elsewhere? It shouldn't have anything to do with this change. |
|
Build failed |
|
We collected some data before the bot timed out, but meanwhile all three modified tests passed on several platforms. So I'll just go through the formalities at this point. @swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver exits out early if there's no stdlib for the target you're compiling for, and these tests didn't pass a target for one reason or another.
rdar://problem/29173390