Eliminate witness markers #5704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test and merge |
|
Oops, this is going to fail: |
Introduce a new operation on generic signatures, enumeratePairedRequirements(), which invokes a callback with each (dependent type, set-of-conformance-requirements) pair that needs to be recorded within substitutions. Switch the last two remaining consumers of witness markers (GenericSignature::getAllDependentTypes() and GenericSignature::getSubstitutions()) over to this new entrypoint.
…tion. Substitution into a generic function type can map type parameters to other type parameters. In some cases, this was introducing duplicate type parameters, e.g., if two type parameters in the original signature mapped down to a single type parameter in the substituted signature. Sort/unique the resulting type parameters so we don't break invariants.
DougGregor
force-pushed
the
eliminate-witness-markers
branch
from
7651738 to
15db826
Compare
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request eliminates the notion of "witness markers" from the frontend. To do so, introduce a new operation on generic signatures,
enumeratePairedRequirements(), which invokes a callback with each(dependent type, set-of-conformance-requirements) pair that needs to
be recorded within substitutions. Switch the last two remaining
consumers of witness markers (
GenericSignature::getAllDependentTypes()and
GenericSignature::getSubstitutions()) over to this new entrypoint. Then delete all notions of witness markers.