Skip to content

Small Fixups #5769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 14, 2016
Merged

Small Fixups #5769

merged 4 commits into from
Nov 14, 2016

Conversation

gottesmm
Copy link
Contributor

This PR contains a few small fixes:

  1. Small formatting fixes to SILValue.h.
  2. Changes SILArgument::getIncomingValue() to assert if the incoming BB does not have any incoming value. This is more correct.
  3. Changes ValueBase::{getParentBB,getFunction,getModule}() to work with const ValueBase *. This makes it possible to get these values in the debugger regardless of if one has a const value or not.
  4. I renamed ValueBase::getParentBB() => getParentBlock(). Over time, we have been going more towards using complete names for block.

@gottesmm
[silvalue] Some small formatting fixes.
f5ef3f3
@gottesmm
[gardening] Instead of returning SILValue() when finding incoming val…
6b74f15 
…ues from a block with unreachable, return, throw terms, assert.

If we ever hit this code path, the program is malformed since this terminators
imply that the block has no successors.
@gottesmm
[gardening] Change ValueBase::{getParentBB,getFunction,getModule}() t…
c6c9914 
…o be const methods so in the debugger one can use it with const ValueBase.
@gottesmm
[gardening] Rename ValueBase::getParentBB() => getParentBlock().
a8c4cc6
@gottesmm gottesmm force-pushed the small_gardening_fixups branch from 168e7bd to a8c4cc6 Compare November 14, 2016 08:40
@gottesmm
Copy link
Contributor Author

@swift-ci Please smoke test and merge

@swift-ci swift-ci merged commit 72b2c48 into swiftlang:master Nov 14, 2016
@gottesmm gottesmm deleted the small_gardening_fixups branch November 14, 2016 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gottesmm @swift-ci