[Type Checker] Improve interface to TypeChecker::conformsToProtocol().
#5782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function had a weird, pre-ProtocolConformanceRef interface that returned true when the type conformed to the protocol, then had a separate indirect return value for the concrete conformance (if there is one). Refactor this API, and the similar TypeChecker::containsProtocol(), to produce an optional ProtocolConformanceRef, which is far more idiomatic and easier to use. Push ProtocolConformanceRef into a few more places. Should be NFC
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function had a weird, pre-
ProtocolConformanceRefinterface thatreturned true when the type conformed to the protocol, then had a
separate indirect return value for the concrete conformance (if there
is one). Refactor this API, and the similar
TypeChecker::containsProtocol(), to produce an optionalProtocolConformanceRef, which is far more idiomatic and easier touse. Push
ProtocolConformanceRefinto a few more places. Should be NFC