Marking .abs() method for floating point types as obsolete in Swift 4 #5810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
You can still mark them as deprecated in Swift 3.1 as well! |
|
@swift-ci Please smoke test Linux platform |
...and deprecated in Swift 3.1
|
Updated. |
rintaro
reviewed
Nov 16, 2016
| @@ -336,9 +336,11 @@ extension CGFloat { | |||
| fatalError("unavailable") | |||
| } | |||
|
|
|||
| @available(*, unavailable, message: "Please use the `abs(_:)` free function") | |||
| @available(swift, deprecated: 3.1, message: "Please use the `abs(_:)` free function") | |||
| @available(swift, obsoleted: 4.0, message: "Please use the `abs(_:)` free function") | |||
There was a problem hiding this comment.
@available(swift, deprecated: 3.1, obsoleted: 4.0, message: "...")doesn't work?
There was a problem hiding this comment.
Good question. Now that you've mentioned it, I think it should.
|
@swift-ci Please smoke test and merge |
|
Unrelated swiftpm test failure. |
|
@swift-ci Please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the name of source compatibility, the
abs()static methods return to all floating point types.Resolves rdar://problem/28456614.