Skip to content

Revert "Simpler implementation for multiple matching patterns in case with variable bindings" #5825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2016
Merged

Revert "Simpler implementation for multiple matching patterns in case with variable bindings" #5825

merged 1 commit into from
Nov 17, 2016

Conversation

jckarter
Copy link
Contributor

@jckarter jckarter commented Nov 16, 2016 •
edited by najacque
Loading

This reverts commit 9508fdc from #5094. Reemitting
case bodies doesn't work if the body contains nested closures or
declarations, since SILGen expects these to only ever be visited once.

rdar://problem/29252758

@jckarter
Revert "Simpler implementation for multiple matching patterns in case…
9348059 
… with variable bindings"

This reverts commit 9508fdc from swiftlang#5094. Reemitting
case bodies doesn't work if the body contains nested closures or
declarations, since SILGen expects these to only ever be visited once.
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 9348059
Test requested by - @jckarter

@jckarter
Copy link
Contributor Author

@ddunbar This swiftpm failure look familiar? Expected?

/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swiftpm/Tests/CommandsTests/PackageToolTests.swift:373: error: PackageToolTests.testPinning : XCTAssertEqual failed: ("5
13:23:05 ") is not equal to ("6
13:23:05 ") -

@swift-ci
Copy link
Contributor

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 9348059
Test requested by - @jckarter

@jckarter
Copy link
Contributor Author

Failures in the full test look unrelated; trying a smoke test.

@jckarter
Copy link
Contributor Author

@swift-ci Please smoke test

@jckarter
Copy link
Contributor Author

@shahmishal Is the CI having issues? The Linux smoke test timed out.

@jckarter
Copy link
Contributor Author

@swift-ci Please smoke test OS X

@jckarter
Copy link
Contributor Author

@swift-ci Please smoke test Linux

@shahmishal
Copy link
Member

last one looks like swiftpm issue:

/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swiftpm/Tests/CommandsTests/PackageToolTests.swift:373: error: PackageToolTests.testPinning : XCTAssertEqual failed: ("5
13:23:05 ") is not equal to ("6
13:23:05 ") -

@jckarter jckarter merged commit 4cd3aad into swiftlang:master Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jckarter @swift-ci @shahmishal