Refactor _swift_stdlib_getUnsafeArgvArgc() #58419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
requested review from
compnerd,
mikeash,
kubamracek,
CodaFi and
al45tair
|
@swift-ci please test |
compnerd
reviewed
Apr 26, 2022
grynspan
force-pushed
the
jgrynspan/commandline-refactor
branch
from
d140cf8 to
3fc8e23
Compare
|
@swift-ci please test |
compnerd
approved these changes
Apr 26, 2022
mikeash
approved these changes
Apr 27, 2022
…ew platform support
grynspan
changed the title
grynspan
force-pushed
the
jgrynspan/commandline-refactor
branch
from
3fc8e23 to
7836f25
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors
_swift_stdlib_getUnsafeArgvArgc()to reduce boilerplate between platform-specific implementations and hopefully make the code more legible.The idea is that, for platforms where
argc/argvcan be read cheaply, we can return them immediately (viaswift::getUnsafeArgvArgc()), and for platforms where it requires processing/iteration, we can fall back toswift::enumerateUnsafeArgv().)