Skip to content

[5.7] fix a crash/hang in SimplifyCFG. #58443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2022

Conversation

eeckstein
Copy link
Contributor

Jump threading in an unreachable CFG region can lead to a crash (in an assert compiler) or hang (in an no-assert compiler) in ValueBase::replaceAllUsesWith.

Unfortunately I couldn't come up with an isolated SIL test case.

rdar://92267349

Jump threading in an unreachable CFG region can lead to a crash (in an assert compiler) or hang (in an no-assert compiler) in `ValueBase::replaceAllUsesWith`.

Unfortunately I couldn't come up with an isolated SIL test case.

rdar://92267349
@eeckstein eeckstein requested a review from a team as a code owner April 27, 2022 08:22
@eeckstein eeckstein added the r5.7 label Apr 27, 2022
@eeckstein
Copy link
Contributor Author

@swift-ci test

@tbkka
Copy link
Contributor

tbkka commented May 3, 2022

Cherry-pick of #58387

@eeckstein eeckstein merged commit 1700295 into swiftlang:release/5.7 May 3, 2022
@eeckstein eeckstein deleted the fix-simplify-cfg-5.7 branch May 3, 2022 16:55
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.7 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants