Skip to content

[cxx-interop] Add basic C++ stdlib overlay #58452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2022
Merged

Conversation

egorzhdan
Copy link
Contributor

This will allow us to add Swift conformances to C++ standard library types, and improve usability of the C++ standard library from Swift.

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Apr 27, 2022
@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-stdlib-overlay branch from eb99836 to 11b5832 Compare April 27, 2022 17:04
Copy link
Contributor

@zoecarver zoecarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super exciting!

@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-stdlib-overlay branch 4 times, most recently from 809d7cd to 5b2c31d Compare April 29, 2022 20:20
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-stdlib-overlay branch from 5b2c31d to d9b1d3e Compare May 4, 2022 12:41
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-stdlib-overlay branch from d9b1d3e to 0e97ba5 Compare May 6, 2022 17:08
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

1 similar comment
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

1 similar comment
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor Author

I added one more commit with a general C++ interop change, not specific to the overlay, to fix verify_all_overlays.py.
@zoecarver can you please take another look?

@egorzhdan egorzhdan marked this pull request as ready for review May 9, 2022 15:51
@egorzhdan egorzhdan requested a review from zoecarver May 9, 2022 15:51
egorzhdan added 2 commits May 16, 2022 13:30
This will allow us to add Swift conformances to C++ standard library types, and improve usability of the C++ standard library from Swift.
…ized module interface

`.swiftinterface` files contain a list of compiler flags that were used to build the module. For example, the list includes `-enable-objc-interop`. It should also include `-enable-experimental-cxx-interop`, since it affects the way the module should be imported.
@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-stdlib-overlay branch from 1760d77 to 74d22e7 Compare May 16, 2022 12:31
@egorzhdan
Copy link
Contributor Author

Discussed offline last week, will merge this as soon as the tests pass (re-rerunning to make sure libswift doesn't break).

@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor Author

@swift-ci please test Windows

@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-stdlib-overlay branch from b5e1c47 to bfb2b16 Compare May 16, 2022 17:08
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan force-pushed the egorzhdan/cxx-stdlib-overlay branch from bfb2b16 to 74d22e7 Compare May 16, 2022 17:28
@egorzhdan egorzhdan merged commit ed17a85 into main May 16, 2022
@egorzhdan egorzhdan deleted the egorzhdan/cxx-stdlib-overlay branch May 16, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants