[Sema] Improving implicit closure capture diagnostic wording #58456
+93
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
reviewed
Apr 28, 2022
LucianoPAlmeida
force-pushed
the
SR-16092-diagnostics
branch
6 times, most recently
from
b4ce726 to
ffe49a3
Compare
LucianoPAlmeida
force-pushed
the
SR-16092-diagnostics
branch
2 times, most recently
from
e74c0bb to
e0df1c6
Compare
LucianoPAlmeida
force-pushed
the
SR-16092-diagnostics
branch
from
e0df1c6 to
3928ccf
Compare
|
@swift-ci Please test |
|
@kavon Friendly ping for a review =] |
LucianoPAlmeida
force-pushed
the
SR-16092-diagnostics
branch
from
3928ccf to
21ec80f
Compare
|
@swift-ci Please test |
kavon
approved these changes
May 24, 2022
|
@swift-ci please test and merge |
No worries @kavon, thanks for the review! |
LucianoPAlmeida
force-pushed
the
SR-16092-diagnostics
branch
from
21ec80f to
d95cd97
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows Platform |
|
@swift-ci Please test MacOS Platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve diagnostic wording for implicit closure captures such as
async letcapture.Resolves SR-16092.
Fixes #58351