[AutoDiff] Ensure adjoint buffer of unchecked_take_enum_data_addr is zeroed after value is accumulated #58457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r value is accumulated. Fixes swiftlang#58353
asl
changed the title
|
Tagging @rxwei @BradLarson |
|
@swift-ci please test |
rxwei
approved these changes
Apr 27, 2022
|
@compnerd Interesting enough, windows tests say that "No test results found". Though looks like all tests were run and succeeded. Is this expected? |
|
@asl - that is .... interesting; @shahmishal can we get that sorted out please? But, yes, it seems that the tests passed, so that should be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another optional-related bug. It could be triggered if
unchecked_take_enum_data_addris inside a loop. In such case the accumulated value of adjoint buffer would be re-used in the subsequent loop iterations producing wrong results.Fixes #58353 (SR16094)