Sidetables should not use operator new or operator delete.
#58459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
grynspan
commented
Apr 27, 2022
| @@ -1329,6 +1330,9 @@ class HeapObjectSideTableEntry { | |||
| #endif | |||
| { } | |||
|
|
|||
| void *operator new(size_t) = delete; | |||
There was a problem hiding this comment.
I might have to pull these lines out, but the idea is to catch any errant uses of new or delete on this type.
mikeash
approved these changes
Apr 27, 2022
grynspan
force-pushed
the
jgrynspan/avoid-operator-new-for-sidetables
branch
2 times, most recently
from
4f1476a to
32fc8c0
Compare
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/avoid-operator-new-for-sidetables
branch
from
32fc8c0 to
0fdad9e
Compare
|
@swift-ci please test |
grynspan
force-pushed
the
jgrynspan/avoid-operator-new-for-sidetables
branch
from
0fdad9e to
19e954f
Compare
grynspan
changed the title
operator new or operator delete.operator new or operator delete.
|
@swift-ci please test |
|
I don't know this part of the codebase very well, but it seems reasonable. Thanks Jonathan. |
mikeash
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sidetables should not use
operator neworoperator delete. This change switches them over toswift_cxx_newObject()andswift_cxx_deleteObject()which wrapswift_slowAlloc()andswift_slowDealloc()respectively.Why is this important? Because these operators can be overridden globally by code in other modules. Imagine a game that has a custom memory allocator (a common scenario!) The developers of this game may want to have all C++ allocations go through their custom allocator. Now, what happens if they implement the guts of this allocator in Swift (in whole or in part)? Well… better hope you never need to allocate a sidetable while you're in there.