[5.7]🍒Ensure clocks properly respect leeways and use raw time for calculations for continuous clocks #58472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons for continuous clocks (swiftlang#58396) * Ensure clocks properly respect leeways and use raw time for calculations for continuous clocks * slurp up time calcualtions to inline forms * ensure the tolerance codepaths get tested as well * Use task local storage for task sources in leeway based calculations * use comparison assertions for leeway based calculations * Whitespace cleanup * Use the CLOCK_MONOTONIC value for linux to be compatible with linux scheduling for dispatch * remove incorrect paren in macro check for OpenBSD * Address feedback and remove stray ;
|
@swift-ci please smoke test |
|
@swift-ci please test |
stephentyrone
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #58396
Continuous clocks incorrectly used non raw clock values (which could result in missing time frames in cases where the raw clock did not align with dispatch's expectations).
This aligns those expectations further as well as handling the leeway functions for the clock sources.
Risk: Low