[5.7][ConstraintSystem] "too complex" diagnostic improvements #58488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the "too complex" would be detected by `ComponentStep::take` but binding steps would still proceed until the producer is exhausted because it considers failure of the previous resume to be just a failed choice. (cherry picked from commit 03fab67)
…fore computing anything (cherry picked from commit e2b4759)
Solver can now handle multiple different targets e.g. multi-statement closures, result builders etc. So it's more appropriate to say that the constraint system is too complex. (cherry picked from commit 7dab90c)
This would help to diagnose the initial point where constraint system has been determine to be "too complex" (cherry picked from commit ef2f24b)
…ex' failures (cherry picked from commit a40e8e8)
(cherry picked from commit 7869b73)
|
@swift-ci please test |
hborla
approved these changes
Apr 28, 2022
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #42605
Cherry-pick of #58400